Fix for Gpsdrive-Kismet-Mysql bug posted

Dutch · 06-24-2005

If you use GPSDrive with Kismet and mysql the following posted to the GPSDrive mailing list by yours truely might be of interest :

Quote:

Originally Posted by Gpsdrive mailing list

As previously noted on the list, gpsdrive fails inserting or updating accesspoint data in the mysql database, if the SSID of the accesspoint contains a "\" character.
WinXP bleads bits of memory into proberequests, so sometimes kismet detects an AP in the form of "^F^G^[^\" which then makes GPSDrive dump to desktop due to a malformed SQL query for inserting or updating the data.

Checking the gpskismet.c file, the reason is clear. The escape routine is wrong.

The enclosed patch for the 2.10pre3 code pulled from cvs today, fixes the escape routine and adds a printout of the orig SSID and the escaped SSID when gpsdrive is run with debug enabled.

Save the patch to the toplevel gpsdrive source directory and apply it the command :
patch -n src/gpskismet.c fixkismetescape.patch

B. Rgds

Dutch (from the NS forums)

Patch enclosed here as well. Remove the .txt suffix if following the above advice on how to apply it.

Dutch

King_Ice_Flash · 06-24-2005

Nice. I was trying to figure out why mine stopped working.

Dutch · 06-24-2005

Quote:

Originally Posted by King_Ice_Flash

Nice. I was trying to figure out why mine stopped working.

You should have asked..

And a correction, it's not the "/" character, but the "\" character that generate the malformed SQL query, and it's the escaping of this char that is fixed by the patch.
It should work on 2.09 as well, so no need to go to 2.10pre3 unless you want to.

Dutch

Dutch · 07-02-2005

New updated patch, that fixes what I broke with the previous patch, which just shows you shouldn't be coding when under the influence of morphine...

This patch, which should be applied to the original gpskismet.c from the gpsdrive 2.10pre3 cvs checkout, properly escapes the characters in a SSID, that will generate a malformed SQL update or insert query. Just as the previous patch, it also adds a printout of the original SSID and the escaped SSID, if gpsdrive is run with debug output enabled.

The patch should be saved in the toplevel gpsdrive source directory, and applied with the command :
patch -p0 -l < newfixkismetescape.patch.txt

The patch can also be applied to the gpsdrive 2.09 source, with the same command, and has been tested with that version as well.

Sorry for the inconvenience...

Dutch

King_Ice_Flash · 07-02-2005

What did you break? The previous patch worked for me.

Dutch · 07-02-2005

Quote:

Originally Posted by King_Ice_Flash

What did you break? The previous patch worked for me.

Yep, right until you run into a SSID like "KIF's WLan"...

This patch escapes not just the \ character which you often get in one of the WinXP memorybleaded proberequests, but also the ' and " characters, which should take care of them all.

Now we just need a patch to take care of that G8t3k33per character... Untill we get that, we have to settle for pouring whisky in him...

Dutch

Dutch · 07-04-2005

Fix has been applied to the current gpsdrive 2.10pre3 version in the CVS repository, including an additional fix for the regular SQL feature of gpsdrive.
The additional fix, has been also been posted on the gpsdrive mailing list, and is included here for good measure.
Save the patch to the toplevel gpsdrive source directory and apply with the following command :
patch -p0 -l < fix_gpssql_escape.patch.txt
then recompile gpsdrive.
Can also be applied to the gpsdrive 2.09 sources, if you prefer to run a stable version.

Dutch

King_Ice_Flash · 07-20-2005

Quote:

Originally Posted by Dutch

Fix has been applied to the current gpsdrive 2.10pre3 version in the CVS repository, including an additional fix for the regular SQL feature of gpsdrive.

Does this mean that if you use the CVS version, you will not need the fix?

Dutch · 07-21-2005

Quote:

Originally Posted by King_Ice_Flash

Does this mean that if you use the CVS version, you will not need the fix?

That is correct. At least if you have pulled the CVS version down, and compiled it AFTER the 4'th of July 2005.

Dutch

King_Ice_Flash · 07-21-2005

Quote:

Originally Posted by Dutch

That is correct. At least if you have pulled the CVS version down, and compiled it AFTER the 4'th of July 2005.

Dutch

Too bad I can't get it to compile.

Dutch · 07-21-2005

Quote:

Originally Posted by King_Ice_Flash

Too bad I can't get it to compile.

What error messages do you get ?
Have you got all the required dependencies installed, including their dev counterparts ?
If you need help, PM me a MSN id, and I'll talk you through it.

Dutch

06-24-2005	#2 (permalink)
King_Ice_Flash Alien Paranoid Stumbler Join Date: May 2003 Location: WI Posts: 2,688	Nice. I was trying to figure out why mine stopped working. __________________ "Yeah," said a voice from under the table, "you go to pieces so fast people get hit by the shrapnel."

07-02-2005	#5 (permalink)
King_Ice_Flash Alien Paranoid Stumbler Join Date: May 2003 Location: WI Posts: 2,688	What did you break? The previous patch worked for me. __________________ "Yeah," said a voice from under the table, "you go to pieces so fast people get hit by the shrapnel."

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode